Closed Bug 1856795 Opened 2 years ago Closed 2 years ago

Enable and run readability-redundant-member-init

Tracking

(firefox120 fixed)

Status:

RESOLVED FIXED

Tracking Flags:

Tracking

Status

firefox120

---

fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 2 obsolete files)

Bug 1856795 - Remove redundant member init r?andi,emilio 2 years ago Sylvestre Ledru [:Sylvestre] 48 bytes, text/x-phabricator-request		Details \| Review
WIP: Bug 1856795 - Remove redundant member init r?andi,emilio 2 years ago Sylvestre Ledru [:Sylvestre] 48 bytes, text/x-phabricator-request		Details \| Review
WIP: Bug 1856795 - Remove redundant member init r?andi,emilio 2 years ago Sylvestre Ledru [:Sylvestre] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1856795 - Enable readability-redundant-member-init r?#linter-reviewers 2 years ago Sylvestre Ledru [:Sylvestre] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1856795 - ride along: use = default; on some recently modified files r?emilio 2 years ago Sylvestre Ledru [:Sylvestre] 48 bytes, text/x-phabricator-request		Details \| Review

Sylvestre Ledru [:Sylvestre]

Assignee

Description

•

2 years ago

No description provided.

Sylvestre Ledru [:Sylvestre]

Assignee

Comment 1

•

2 years ago

Attached file Bug 1856795 - Remove redundant member init r?andi,emilio — Details

Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Sylvestre Ledru [:Sylvestre]

Assignee

Comment 2

•

2 years ago

Attached file WIP: Bug 1856795 - Remove redundant member init r?andi,emilio (obsolete) — Details

Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Sylvestre Ledru [:Sylvestre]

Assignee

Comment 3

•

2 years ago

Attached file WIP: Bug 1856795 - Remove redundant member init r?andi,emilio (obsolete) — Details

Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Phabricator Automation

Updated

•

2 years ago

Attachment #9356524 - Attachment description: WIP: Bug 1856795 - Remove redundant member init r?andi,emilio → Bug 1856795 - Remove redundant member init r?andi,emilio

Sylvestre Ledru [:Sylvestre]

Assignee

Comment 4

•

2 years ago

Attached file Bug 1856795 - Enable readability-redundant-member-init r?#linter-reviewers — Details

Depends on D190002

Pulsebot

Comment 5

•

2 years ago

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f37a30bf6db0 Enable readability-redundant-member-init r=linter-reviewers,ahal DONTBUILD

Phabricator Automation

Updated

•

2 years ago

Attachment #9356526 - Attachment is obsolete: true

Phabricator Automation

Updated

•

2 years ago

Attachment #9356530 - Attachment is obsolete: true

Sandor Molnar[:smolnar]

Comment 6

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/f37a30bf6db0

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox120: --- → fixed

Resolution: --- → FIXED

Sylvestre Ledru [:Sylvestre]

Assignee

Updated

•

2 years ago

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

BugBot [:suhaib / :marco/ :calixte]

Updated

•

2 years ago

status-firefox120: fixed → affected

Mathew Hodson

Updated

•

2 years ago

Component: Lint and Formatting → Source Code Analysis

Noemi Erli[:noemi_erli]

Updated

•

2 years ago

Regressions: 1857550

Sylvestre Ledru [:Sylvestre]

Assignee

Comment 7

•

2 years ago

Attached file Bug 1856795 - ride along: use = default; on some recently modified files r?emilio — Details

Command:
L=$(hg export -r tip|grep +++|cut -d/ -f2-)
./mach static-analysis check --checks="-*, modernize-use-equals-default" --fix $L

Pulsebot

Comment 8

•

2 years ago

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eae2ac93e17c Remove redundant member init r=emilio https://hg.mozilla.org/integration/autoland/rev/1d98b028923a ride along: use = default; on some recently modified files r=emilio

Cristina Horotan [:chorotan]

Comment 9

•

2 years ago

Backed out 2 changesets (bug 1856795) for causing build bustage at BasicEvents.h

Backout: https://hg.mozilla.org/integration/autoland/rev/b2a0801ae53cd4b890942a941a41073bf3bd3615

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1d98b028923a6380edea696a19acc202fd5c1202

Failure log: https://treeherder.mozilla.org/logviewer?job_id=432505610&repo=autoland&lineNumber=59299

Flags: needinfo?(sledru)

Pulsebot

Comment 10

•

2 years ago

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94ff2d8f87dd Remove redundant member init r=emilio https://hg.mozilla.org/integration/autoland/rev/aba20bc488e2 ride along: use = default; on some recently modified files r=emilio

Iulian Moraru

Comment 11

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/94ff2d8f87dd
https://hg.mozilla.org/mozilla-central/rev/aba20bc488e2

Status: REOPENED → RESOLVED

Closed: 2 years ago → 2 years ago

status-firefox120: affected → fixed

Resolution: --- → FIXED

Sylvestre Ledru [:Sylvestre]

Assignee

Updated

•

2 years ago

Flags: needinfo?(sledru)

You need to log in before you can comment on or make changes to this bug.